Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart renewal service after issuing new cert with CA, reload affected services #451

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Restart renewal service after issuing new cert with CA, reload affected services #451

merged 4 commits into from
Dec 24, 2024

Conversation

ported-pw
Copy link
Contributor

This fixes #450 by always restarting the step-renew service after certificate re-issuance, and reloading desired services just like the step-renew service would.

@ported-pw ported-pw requested a review from maxhoesel as a code owner November 15, 2024 15:12
@maxhoesel maxhoesel added the pr-patch This PR introduces a bugfix (-> patch release) label Dec 24, 2024
maxhoesel
maxhoesel approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@maxhoesel maxhoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The CI errors are flaky and can be ignored, squashing

@maxhoesel maxhoesel merged commit 1733ad2 into maxhoesel-ansible:main Dec 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhoesel maxhoesel maxhoesel approved these changes

Assignees
No one assigned
Labels
pr-patch This PR introduces a bugfix (-> patch release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

step_acme_cert: Issuing a new certificate needs to stop step-renew and start it back up again
2 participants
@ported-pw @maxhoesel